UVCXR/Simulation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lh/20250429 #9

Merged
Ghost merged 2 commits from lh/20250429 into main 2025-04-30 12:21:56 +09:00
Conversation 1 Commits 2 Files Changed 13 +799 -4
lh commented 2025-04-30 12:18:10 +09:00
Collaborator
Copy Link
No description provided.
lh added 2 commits 2025-04-30 12:18:11 +09:00
Update MQTTManager.cs
All checks were successful
Code Review / code-review (pull_request) Successful in 6s
Details
b664497c79
webmanager
All checks were successful
Code Review / code-review (pull_request) Successful in 8s
Details
60eae20b92
lh commented 2025-04-30 12:18:20 +09:00
Author
Collaborator
Copy Link

Raktbeej Code Review:

Summary:

The code changes you provided are modifications to a Unity project. The changes include the addition of new files and modifications to an existing one. Here’s a brief breakdown of the changes:

  1. New Files Added:

    • WebConfig.json in Assets/StreamingAssets/ - This JSON file contains server configuration details like host, port, and accessToken.
    • BaseSimulationMessage.cs in Assets/WorkSpace/LH/ - This file defines a serializable C# class that models a base simulation message used in the project.
    • WebConfig.cs in Assets/WorkSpace/LH/ - This file defines classes for handling web configuration, including WebConfigList and WebConfig.

  2. Changes in Existing Files:

    • MQTTManager.cs in Assets/WorkSpace/LH/:
      • Added a new field basemessage of type BaseSimulationMessage.
      • Added properties to handle MQTT topic subscription (_topic and topic).
      • Added a method UnsubscribeTopic to handle unsubscribing from a topic.
      • Modified existing methods to integrate topic property.
      • Modified the OnMessage method to deserialize incoming MQTT messages into a BaseSimulationMessage object.

  3. Meta Files:

    • .meta files are Unity-specific metadata files that store information about assets such as GUIDs. New meta files were added corresponding to the new C# files and JSON configuration to ensure Unity can properly reference and manage these resources.

These changes appear to be about integrating MQTT functionality within a Unity project, handling simulation messages, and managing configuration details via JSON. Adjustments to MQTTManager enhance the MQTT subscription model and incorporate deserialization of messages into structured types.

Raktbeej Code Review: ## Summary: The code changes you provided are modifications to a Unity project. The changes include the addition of new files and modifications to an existing one. Here’s a brief breakdown of the changes: 1. **New Files Added:** - `WebConfig.json` in `Assets/StreamingAssets/` - This JSON file contains server configuration details like `host`, `port`, and `accessToken`. - `BaseSimulationMessage.cs` in `Assets/WorkSpace/LH/` - This file defines a serializable C# class that models a base simulation message used in the project. - `WebConfig.cs` in `Assets/WorkSpace/LH/` - This file defines classes for handling web configuration, including `WebConfigList` and `WebConfig`. 2. **Changes in Existing Files:** - `MQTTManager.cs` in `Assets/WorkSpace/LH/`: - Added a new field `basemessage` of type `BaseSimulationMessage`. - Added properties to handle MQTT topic subscription (`_topic` and `topic`). - Added a method `UnsubscribeTopic` to handle unsubscribing from a topic. - Modified existing methods to integrate `topic` property. - Modified the `OnMessage` method to deserialize incoming MQTT messages into a `BaseSimulationMessage` object. 3. **Meta Files:** - `.meta` files are Unity-specific metadata files that store information about assets such as GUIDs. New meta files were added corresponding to the new C# files and JSON configuration to ensure Unity can properly reference and manage these resources. These changes appear to be about integrating MQTT functionality within a Unity project, handling simulation messages, and managing configuration details via JSON. Adjustments to `MQTTManager` enhance the MQTT subscription model and incorporate deserialization of messages into structured types.
Ghost merged commit a78c97deb8 into main 2025-04-30 12:21:56 +09:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
khi khm6376 lh lwj njh UVCXR
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: UVCXR/Simulation#9
Delete Branch "lh/20250429"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?